Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings
This repository was archived by the owner on May 25, 2022. It is now read-only.

Scraping quotes #194

Merged
tusharnankani merged 4 commits into Python-World:master from anandhakrishnanaji:scraping_quotes
Sep 7, 2020
Merged

Scraping quotes #194

tusharnankani merged 4 commits into Python-World:master from anandhakrishnanaji:scraping_quotes
Sep 7, 2020

Conversation

Copy link
Contributor

@anandhakrishnanaji anandhakrishnanaji commented Sep 7, 2020 •
edited
Loading

Description

I have scraped quotes from the URL using beautifulsoup and requests module

Fixes #188

Replace issue_no in the above line with the issue related to this PR.

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull request

  • I have named my files and folder according to this project's guidelines
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have included a requirements.txt file(if external libraries are required)
  • My changes dont produce any warnings.
  • I have added a working sample/screenshot of the script

Copy link
Member

@tusharnankani tusharnankani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anandhakrishnanaji!

Works well and good! Well commented!

Could you edit the README.md according to the Readme Template?

Keep it up! ^_^
Tushar Nankani

anandhakrishnanaji reacted with laugh emoji
Copy link
Contributor Author

Thankyou @tusharnankani,

Changes are made.

Copy link
Member

@tusharnankani tusharnankani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! @anandhakrishnanaji
Merging the PR! 👍🏻

anandhakrishnanaji reacted with heart emoji
@tusharnankani tusharnankani merged commit 793d77d into Python-World:master Sep 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@tusharnankani tusharnankani tusharnankani approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scrape quote from http://quotes.toscrape.com/

AltStyle によって変換されたページ (->オリジナル) /