-
Notifications
You must be signed in to change notification settings - Fork 5.6k
add change to a random background script #122
Conversation
anyone have windows machine please review this code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kana800 ,
evrything good and working. But do note that SystemParametersInfoA( ) method is used for windows 32bit while SystemParametersInfoW( ) method is used with 64 bit system.
So, do add an function to check user windows system and uses required method accordingly.
@ShivSt Thanks for the review 👍🏾 ,
Didnt know about that, I will work on it 😃
Thanks @ShivSt for review the code
😄
@chavarera All the changes are fixed 😄 .
Now the user can enter windows version and the background will be changed.
@ShivSt
Please Review the code if possible. 🙏🏾
😄
@kana800 it should work. But, most often than not user don't know which version of windows they are using. So, it will be better to provide that automatically by checking system configuration.
User should just click on the script and bg should change.
@ShivSt I am not familiar with windows so I had a some tough time testing this script out.
Thanks again for the review! 😄 🙏🏾
Really appreciate it !
I think everything should workout fine now
good work @kana800 so i am merging this pull request in next version you can add auto version detect code or i will asign this issue to someone who is interested in it
#99