@fkiraly

instead of editing tickers mentioned in the cookbook notebooks, i added 2 csv files to pypfopt/data. stock_prices.csv and market_caps.csv with only data from 2023 onwards. the stock_prices.csv is around 450kb.

also removed yfinance related statements and functions from all notebooks

@fkiraly

market_caps.csv and stock_prices.csv now contain data produced synthetically with Geometric Brownian Motion.

Thanks! Could you kindly post here the plots in the notebooks before/after, just to check if they look similar?

also, code formatting tests are failing, please look at pre-commit

i have run pre-commit and pushed the changes.

plots you asked for:

previous data plot with data from yfinance:
image

synthetic data plot from brownian motion:
image

Thanks!

I suspect the actual data would be closer to exponential Brownian motion - that should be achieved by simply taking np.exp of the Brownian motion.

non-blocking - would it be possible to include the simulation code somewhere in the utils module?

I suspect the actual data would be closer to exponential Brownian motion - that should be achieved by simply taking np.exp of the Brownian motion.

i am confused. the code i used to generate the synthetic data uses exponential brownian motion.

for t in range(1, n_days):
 z = np.random.normal(size=len(tickers))
 prices[t] = prices[t-1] * np.exp(
 (mu - 0.5 * sigma**2) * dt + sigma * np.sqrt(dt) * z
 )

can you re-execute the notebooks after a clean reset?

yes. i re-executed the cookbook notebooks before making the first commit.

i am confused. the code i used to generate the synthetic data uses exponential brownian motion.

oh, ok - you are right. Then we do not need to change that.

Can you check the pyproject.toml and resolve the merge conflict?

non-blocking - would it be possible to include the simulation code somewhere in the utils module?

i would be happy to, but cant find a utils folder anywhere

@fkiraly

i have made the docstring changes and resolved the conflict. i had exams going on, sorry for the hold-up.

@fkiraly not to bother you, but can this be merged?

Hi @Shuvam586,

I was testing out your code and noticed a couple of things that need to be addressed:

1. Notebooks Crash on Import (ModuleNotFoundError)

In the updated cookbook/*.ipynb notebooks, the first cell still has !pip install PyPortfolioOpt. Running this forces Jupyter to download v1.6.0 from PyPI. Because the notebook is inside cookbook/ and pypfopt is outside in the parent directory, Python ignores your new local code, defaults to the PyPI version, and crashes because it can't find pypfopt.data.

I feel the !pip install command can be removed, and instead add the parent directory to sys.path so Python checks the local files first:

import sys
import os
sys.path.insert(0, os.path.abspath('..'))
import matplotlib.pyplot as plt
from pypfopt.data.data_loader import load_stockdata

2. Make available_tickers() Dynamic

In data_loader.py, available_tickers() returns a hardcoded list of the 33 companies. If the CSV files ever get updated with new datasets, this function will easily fall out of sync.

To keep this robust, you should dynamically read the column straight from the local CSV:

def available_tickers():
 """
 Return the list of available ticker symbols dynamically from the bundled dataset.
 """
 df = _load_raw_data("market_caps.csv")
 return sorted(df["ticker"].tolist())

hi @amishverma05

1. contributors pip install -e . before working on the repo. this makes the notebooks use the local version of pypfopt instead of the pypi one. using sys.path is unnecessary.
2. @fkiraly suggested in a previous change, to return the list of tickers. it is unlikely the csv file will change. the data is simulated and only acts as an example source.

hi @fkiraly, kindly, is it possible for you to review this pr. has been open for very long.