-
Notifications
You must be signed in to change notification settings - Fork 1.1k
ENH: remove bash execution preambles from cookbook notebooks (#717)#720
Open
Abhishek9639 wants to merge 1 commit into
Open
ENH: remove bash execution preambles from cookbook notebooks (#717) #720Abhishek9639 wants to merge 1 commit into
Abhishek9639 wants to merge 1 commit into
Conversation
Abhishek9639
commented
Mar 2, 2026
Author
@fkiraly,
I’ve opened this PR to address #717. I removed the Colab-specific setup cells (!pip install, git clone, os.chdir) from the five cookbook notebooks since CI already handles dependencies before running the tests. Imports are already covered in pyproject.toml, so no dependency changes were needed. Please review when you get a chance.
If any changes are needed, please let me know.
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ENH] remove bash execution from cookbook notebooks. Closes #717
I’ve removed the bash setup cells from all five cookbook notebooks. These cells were mainly installing packages and cloning the repo, which is only required when running the notebooks on Google Colab.
Since our CI pipeline already installs all required dependencies, before running the notebook tests via nbmake, those setup steps were redundant in this repository.
I double checked that all imports used in the notebooks (numpy, pandas, matplotlib, yfinance, cvxpy, pypfopt) are already covered in pyproject.toml, so no dependency changes were needed.
I also ran the full test suite locally all tests passed.