Bring tabula-calculator-calcsetbuilding data back - #2285

Thanks @yerbol-akhmetov !

I took the liberty of directly committing onto the branch a simplification - inlining the retrieve logic and reading the xlsx file directly rather than writing an intermediary csv file.

Two reasons for doing it this way:

1. We want to only have the original data in the data/ subdirectoy, not parsed or modified (like your csv file) data
2. The retrieve functionality can be simplified and the intermediary csv doesn't really seem necessary. Now the logic is similar to the boilerplate code for the other rules.

Can you test whether the small changes of using the xlsx file directly work and do not cause deviations compared to using the csv file?

Are you fine with this change? Else we can revert my commit.

Thanks @yerbol-akhmetov !

I took the liberty of directly committing onto the branch a simplification - inlining the retrieve logic and reading the xlsx file directly rather than writing an intermediary csv file.

Two reasons for doing it this way:

1. We want to only have the original data in the data/ subdirectoy, not parsed or modified (like your csv file) data
2. The retrieve functionality can be simplified and the intermediary csv doesn't really seem necessary. Now the logic is similar to the boilerplate code for the other rules.

Can you test whether the small changes of using the xlsx file directly work and do not cause deviations compared to using the csv file?

Are you fine with this change? Else we can revert my commit.

Hi, @euronion. Thank you for the improvements. I am totally fine with it.

Hi, @euronion. Regarding two suggestions, all good from my side. It did not change the logic. I was thinking if we could set retro_endogen: true for one of the CI tests (e.g. overnight one), so that we will not miss updating and testing retrofitting scripts. What do you think? Can we implement it in one of the future PRs?