-
Notifications
You must be signed in to change notification settings - Fork 0
CompatHelper: add new compat entry for CircularArrays at version 1, (keep existing compat) #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
github-actions
wants to merge
1
commit into
main
from
compathelper/new_version/2022-01-23-00-42-07-465-01747585785
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...keep existing compat)
@PyDataBlog
PyDataBlog
force-pushed
the
compathelper/new_version/2022-01-23-00-42-07-465-01747585785
branch
from
January 23, 2022 00:42
d8d049c to
62b6544
Compare
Codecov Report
Merging #10 (62b6544) into main (6f71152) will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## main #10 +/- ## ======================================= Coverage 99.32% 99.32% ======================================= Files 5 5 Lines 149 149 ======================================= Hits 148 148 Misses 1 1
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 6f71152...62b6544. Read the comment docs.
@PyDataBlog
PyDataBlog
deleted the
compathelper/new_version/2022-01-23-00-42-07-465-01747585785
branch
January 23, 2022 13:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request sets the compat entry for the
CircularArrayspackage to1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Note: Consider registering a new release of your package immediately after merging this PR, as downstream packages may depend on this for tests to pass.