-
Notifications
You must be signed in to change notification settings - Fork 14
update kmeans docstring, add counts to algos
#121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Expanded docstring of
kmeansfunction to give a simple example. This was the first thing I checked when I started to use the package and didn't see one.I also noticed that the algos don't return counts. I just applied the
countmapfunction fromStatsBasewhich we already depend on.Killer package by the way, it sped up my calculation by an order of magnitude.
Thanks for looking into this and glad that you like the package :)
I will review and looking forward to it eventually going in.
Expanded docstring of
kmeansfunction to give a simple example. This was the first thing I checked when I started to use the package and didn't see one.I also noticed that the algos don't return counts. I just applied the
countmapfunction fromStatsBasewhich we already depend on.Killer package by the way, it sped up my calculation by an order of magnitude.