This repository was archived by the owner on Feb 7, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
Allow users to enforce zero terminal SNR in schedulers - #404
Draft
marksgraham wants to merge 1 commit into
Draft
Conversation
marksgraham
commented
Dec 13, 2023
Collaborator
Author
Closing as I couldn't convince myself there was sufficient benefit to fixing the flaws in experiments.
marksgraham
commented
Mar 15, 2024
Collaborator
Author
Resurrecting PR after discussion in #397 , might not get time to work on this for a while though so it's open for someone else to jump in on
@marksgraham
marksgraham
changed the title
(削除) Fixes flaws in schedulers (削除ここまで)
(追記) Allow users to enforce zero terminal SNR in schedulers (追記ここまで)
Mar 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #397