Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added link to the contact page #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laadysufiia wants to merge 3 commits into ProgrammerGaurav:master
base: master
Choose a base branch
Loading
from laadysufiia:master

Conversation

Copy link

@laadysufiia laadysufiia commented Oct 8, 2020

The link for the Contact tab was missing, so I added it.

Copy link
Owner

@ProgrammerGaurav ProgrammerGaurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not going to merge but will be eligible for Hacktoberfest

laadysufiia reacted with laugh emoji
contact.html Outdated
@@ -41,7 +41,7 @@ <h1 class="">ProgrammerGaurav</h1>
<a title="SKills Navigation" class="nav-link" href="/#skills">Skills</a>
</li>
<li class="nav-item active">
<a title="Contact Navigation" class="nav-link" href="">Contact</a>
Copy link
Owner

@ProgrammerGaurav ProgrammerGaurav Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the page itself is on contact.html so no need redirect again on contact.html

Copy link
Author

@laadysufiia laadysufiia Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, you're right, I've edited the wrong file. You have an issue with the 'Contact' link on your nav bar, when you click it doesn't direct you to the contact page. I've fixed this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProgrammerGaurav ProgrammerGaurav ProgrammerGaurav left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /