Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Small QOL updates #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NinjaLabs-Dev wants to merge 2 commits into ProgrammerGaurav:master from NinjaLabs-Dev:master
Closed

Small QOL updates #2

NinjaLabs-Dev wants to merge 2 commits into ProgrammerGaurav:master from NinjaLabs-Dev:master

Conversation

Copy link

@NinjaLabs-Dev NinjaLabs-Dev commented Oct 6, 2020
edited
Loading

  • Stopped mouse selecting text on about me items
  • Added transition on social icon hover

Copy link
Author

Any update on this?

Copy link
Owner

Any update on this?

I have added hacktoberfest-accepted label to your PR so it is eligible for fest, and I need to review it completely before merging....so it will take some time.....

Copy link
Author

@ProgrammerGaurav No worries! 😄

Copy link
Owner

@ProgrammerGaurav ProgrammerGaurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Code is good but not good enough for merging to the master branch

@@ -4,8 +4,7 @@ body {
margin: 0;
padding: 0;
color: #ffffff;
font-family: 'Ubuntu', sans-serif;
}
font-family: 'Ubuntu', sans-serif; }
Copy link
Owner

@ProgrammerGaurav ProgrammerGaurav Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the CSS changes are because of the Last braces!

color: #000000;
}
transition-duration: 0.5s; }
.navbar .navbar-brand {
Copy link
Owner

@ProgrammerGaurav ProgrammerGaurav Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS is not formatted, and not an imp change

@@ -93,27 +73,22 @@ div.type-wrap {
font-weight: bold;
top: 50%;
left: 50%;
-webkit-transform: translate(-50%, -50%);
Copy link
Owner

@ProgrammerGaurav ProgrammerGaurav Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebKit is important deleting can cause problem

transition: all 0.3s;
-webkit-box-shadow: 0 0 50px 5px #b1b1b1;
Copy link
Owner

@ProgrammerGaurav ProgrammerGaurav Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Webkit deleted

padding-right: 20px;
padding-left: 20px;
}
text-align: center; }
Copy link
Owner

@ProgrammerGaurav ProgrammerGaurav Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same Code no change!

height: 254px;
padding: 10px;
}
text-align: center; }
Copy link
Owner

@ProgrammerGaurav ProgrammerGaurav Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same Code no change!

color: #fff;
background-color: #444444;
}
background-color: #FAFAFA; }
Copy link
Owner

@ProgrammerGaurav ProgrammerGaurav Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same Code no change!

@@ -131,6 +131,10 @@ div.type-wrap {
overflow: hidden;
transition: all 0.3s;
box-shadow: 0 0 50px 5px rgb(177, 177, 177);

p {
user-select: none;
Copy link
Owner

@ProgrammerGaurav ProgrammerGaurav Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, and the only good thing in the code

Copy link
Author

@ProgrammerGaurav All of these issues are caused by my scss compiler. Which one did you use so I can replicate the original code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProgrammerGaurav ProgrammerGaurav ProgrammerGaurav left review comments

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /