-
Notifications
You must be signed in to change notification settings - Fork 519
Add createTemporaryIntegratedConsole to attach options
#5247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds the option `createTemporaryIntegratedConsole` to the attach configuration. No changes are needed in the code to enable this scenario as it work without any issues right now.
@Copilot
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a new configuration option createTemporaryIntegratedConsole to the attach debugger configuration in VS Code PowerShell extension. This boolean option allows users to create temporary integrated consoles for debugging sessions, which is particularly useful when debugging PowerShell classes and binary modules.
- Adds
createTemporaryIntegratedConsoleboolean property to attach configuration schema - Provides ability to override the global user setting on a per-configuration basis
- Enables temporary console creation for specific debugging scenarios
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two spaces between sentences in the description. Consider using single spaces for consistency: 'binary modules. Overrides the user setting'
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can but the launch example has the same, wasn't sure if it was intentional or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this is just intellisense niceness
4cea222
into
PowerShell:main
Thanks!
createTemporaryIntegratedConsole to attach options (追記ここまで)
PR Summary
Adds the option
createTemporaryIntegratedConsoleto the attach configuration. No changes are needed in the code to enable this scenario as it work without any issues right now.No changes are needed in PSES to enable this. The logic for spawning the temp console exists in the vscode plugin and not PSES.
PR Checklist
WIP:to the beginning of the title and remove the prefix when the PR is ready