Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add an extended Snippet for Advanced Functions #5203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JustinGrote merged 12 commits into PowerShell:main from kilasuit:5197
Jul 23, 2025

Conversation

Copy link
Contributor

@kilasuit kilasuit commented May 24, 2025 •
edited
Loading

PR Summary

fixes #5197

Added snippet from ISE with minor edits

  • comment help inside instead of outside the function defintion
  • added clean block and link to docs on this

Adding based on this comment on bsky

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@kilasuit kilasuit requested a review from a team as a code owner May 24, 2025 23:25
Copy link
Collaborator

@JustinGrote JustinGrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Godo work on the snippet, I'm not quite sure how useful this is though, maybe it should be renamed Function-Advanced-Doc-Full-Example to indicate it is an example for all the potential options? I personally would never use this, it would take me just as long to clean it up as it would to just write it naked with intellisense :)

Copy link
Contributor Author

@JustinGrote this was a C&P from the one in ISE with very minor edits
But will take comments on board and push an update shortly

Copy link
Collaborator

I'll merge it either way, but good to make it as useful as possible yeah?

@JustinGrote JustinGrote enabled auto-merge (squash) June 1, 2025 15:22
Copy link
Collaborator

@JustinGrote JustinGrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work!

JustinGrote

This comment was marked as duplicate.

Copy link
Collaborator

@andyleejordan not sure why it's waiting on codeql, I don't see it as an action...

Copy link
Collaborator

@andyleejordan bump on this.
image

andyleejordan reacted with thumbs up emoji

@andyleejordan andyleejordan changed the title (削除) Add an extended Snippet for Advanced Functions fixes #5197 (削除ここまで) (追記) Add an extended Snippet for Advanced Functions (追記ここまで) Jul 23, 2025
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JustinGrote JustinGrote merged commit 2093b3e into PowerShell:main Jul 23, 2025
4 checks passed
Copy link
Collaborator

Thanks @kilasuit!

@kilasuit kilasuit deleted the 5197 branch July 23, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

@JustinGrote JustinGrote JustinGrote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an extended Snippet for Advanced Functions

AltStyle によって変換されたページ (->オリジナル) /