-
Notifications
You must be signed in to change notification settings - Fork 521
Fix ForEach-Progress snippet template #5122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andyleejordan
merged 3 commits into
PowerShell:main
from
Cydroz:issue/5086-improve-progress-snippet
Jan 10, 2025
Merged
Fix ForEach-Progress snippet template #5122
andyleejordan
merged 3 commits into
PowerShell:main
from
Cydroz:issue/5086-improve-progress-snippet
Jan 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
andyleejordan
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@andyleejordan
andyleejordan
added
the
Issue-Enhancement
A feature request (enhancement).
label
Jan 8, 2025
@andyleejordan
andyleejordan
merged commit Jan 10, 2025
0c5f2f8
into
PowerShell:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Concerns issue #5086 . PR #5087 Only fixes the validity of the snippet JSON syntax, and not the template itself.
This PR attempts to rectify the actual snippet into something more usable.
PR Checklist
NA) PR has tests