-
Notifications
You must be signed in to change notification settings - Fork 520
Fix: Change DAP send/receive glyph to keep things aligned in the logs #5076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@JustinGrote are you sure you have the right right-arrow? I'd expect to see ➡️ since I'm seeing ⬅️ but I'm seeing ➡️...which I just copy-pasted and it shows correctly here. GitHub isn't rendering it well in the file diff 😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me re-verify but it looked good in code
Files changed tab looks fine to me too in github on the PR:
image
Are you on a Mac or something? Also using edge browser here.
Checking the glyph codepoints they look good to me, so I'm going to go ahead and merge queue it. If we find something's wrong with the code points we can fix-forward, but again since this is just the DAP trace log and not user-facing it's not a big deal either way.
Files changed tab looks fine to me too in github on the PR: image
Are you on a Mac or something? Also using edge browser here.
Yeah, in Edge on a Mac. It's weird! No worries though.
PR Summary
Changes logging glyph from◀️ to ⬅️ which has better ZWF formatting in logs