-
Notifications
You must be signed in to change notification settings - Fork 519
Refactor: Replace package.json requires with extension context info #5071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, thanks!
Quick note that this API is also available in 1.82 which is what Azure Data Studio is on so that should be fine but I haven't directly tested it.
https://github.com/microsoft/vscode/blob/release/1.82/src/vscode-dts/vscode.d.ts#L7077
@JustinGrote we no longer have to support ADS and I bumped our engine to 1.94!
Uh oh!
There was an error while loading. Please reload this page.
PR Summary
The package.json info is now available in the extension context, this avoids a round trip. Note there is no validation on the import of the information (there wasn't before either), but it's very unlikely to surface a null or undefined, or have that affect operation of the extension (famous last words).
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready