-
Notifications
You must be signed in to change notification settings - Fork 520
Find shell integration script for VS Code 1.94+ #5047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/cc @Tyriar though I'm still looking at the envMixin of https://github.com/microsoft/vscode/blob/main/src/vs/platform/terminal/node/terminalProcess.ts#L210 et. al. and debugging trying to confirm if I need to manually add any environment variables to our terminal process launch
vscode-powershell/src/process.ts
Line 119 in efd6fd5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
To confirm what needs to be set I'd check the environment the terminal is being created with. Variables of interest are VSCODE_NONCE (which you're unable to set), VSCODE_STABLE (which blocks some experimental stuff from working in stable)
It got moved. Pulling this out of the OneBranch signing PR. See microsoft/vscode#227244