Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix attachDotnetDebugger with custom config #4517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JustinGrote merged 3 commits into PowerShell:main from fflaten:attach-customdotnetconfig
Apr 14, 2023

Conversation

Copy link
Contributor

@fflaten fflaten commented Apr 13, 2023
edited
Loading

PR Summary

Fixes dotnetDebuggerConfigName-option in launch config when using new attachDotnetDebugger feature introduced in #3903. Always threw config not found-error when dotnetDebuggerConfigName was set.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • [NA] PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@fflaten fflaten requested a review from a team April 13, 2023 20:50
Copy link
Contributor Author

fflaten commented Apr 13, 2023

/cc @JustinGrote Not sure how to add tests for this, but feel free to commit if you know. 🙂

Copy link
Collaborator

Thanks! I'll take it from here!

fflaten reacted with hooray emoji

Copy link
Collaborator

@andschwa test added, ready for review. Thanks again @fflaten for the catch!

fflaten reacted with rocket emoji

@andyleejordan andyleejordan changed the title (削除) Fix attachDotnetDebugger with custom dotnet config (削除ここまで) (追記) Fix attachDotnetDebugger with custom dotnet config (追記ここまで) Apr 14, 2023
@andyleejordan andyleejordan changed the title (削除) Fix attachDotnetDebugger with custom dotnet config (削除ここまで) (追記) Fix attachDotnetDebugger with custom config (追記ここまで) Apr 14, 2023
@JustinGrote JustinGrote merged commit 4d71946 into PowerShell:main Apr 14, 2023
@fflaten fflaten deleted the attach-customdotnetconfig branch April 14, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

Labels
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /