-
Notifications
You must be signed in to change notification settings - Fork 519
Fix attachDotnetDebugger with custom config
#4517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JustinGrote
merged 3 commits into
PowerShell:main
from
fflaten:attach-customdotnetconfig
Apr 14, 2023
Merged
Fix attachDotnetDebugger with custom config
#4517
JustinGrote
merged 3 commits into
PowerShell:main
from
fflaten:attach-customdotnetconfig
Apr 14, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @JustinGrote Not sure how to add tests for this, but feel free to commit if you know. 🙂
Thanks! I'll take it from here!
@andyleejordan
andyleejordan
changed the title
(削除) Fix attachDotnetDebugger with custom dotnet config (削除ここまで)
(追記) Fix Apr 14, 2023
attachDotnetDebugger with custom dotnet config (追記ここまで)
@andyleejordan
andyleejordan
changed the title
(削除) Fix
(追記) Fix Apr 14, 2023
attachDotnetDebugger with custom dotnet config (削除ここまで)attachDotnetDebugger with custom config (追記ここまで)
andyleejordan
andyleejordan
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
PR Summary
Fixes
dotnetDebuggerConfigName-option in launch config when using newattachDotnetDebuggerfeature introduced in #3903. Always threw config not found-error whendotnetDebuggerConfigNamewas set.PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready