Hide last line in folded ranges for ISE Mode #4425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

andyleejordan merged 1 commit into PowerShell:main from fflaten:isemode-folding

Feb 21, 2023

Merged

Hide last line in folded ranges for ISE Mode #4425

andyleejordan merged 1 commit into PowerShell:main from fflaten:isemode-folding

Feb 21, 2023

Conversation

fflaten

Copy link

Contributor

@fflaten fflaten commented Feb 18, 2023

PR Summary

PowerShell ISE folds ranges to a single line unlike the current default in this extension:
image
image

This PR sets the powershell.codeFolding.showLastLine option to false in ISE mode to be more similar with ISE behavior.
image

There is one major difference: ISE appended the closing char for most ranges which VSCode doesn't atm. That might be a dealbreaker, so submitting as a suggestion without discussion. Feel free to close if you don't agree.

PR Checklist

PR has a meaningful title
Summarized changes
PR has tests
This PR is ready to merge and is not work in progress

@fflaten


 Hide last line in folded regions using ISE mode

d69472c

@fflaten fflaten requested a review from a team

February 18, 2023 13:41

@andyleejordan

Copy link

Member

andyleejordan commented Feb 21, 2023

TBH I really like how the ISE handles this, but yeah even without the end characters I think this is good!

@andyleejordan andyleejordan added Issue-Enhancement Area-ISE Compatibility labels

Feb 21, 2023

andyleejordan

andyleejordan approved these changes

Feb 21, 2023

View reviewed changes

@andyleejordan andyleejordan changed the title ~~(削除) ISE Mode: Hide last line in folded ranges (削除ここまで)~~ (追記) Hide last line in folded ranges for ISE Mode (追記ここまで)

Feb 21, 2023