Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Automatically find "PowerShell Daily" at its common path #4331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andyleejordan merged 1 commit into main from andschwa/daily
Dec 19, 2022

Conversation

Copy link
Member

@andyleejordan andyleejordan commented Dec 15, 2022

Resolves #4329 by negating the need to manually add the PowerShell daily path.

TylerLeonhardt reacted with heart emoji
@andyleejordan andyleejordan requested a review from a team December 15, 2022 00:45
@ghost ghost added Area-Startup Issue-Bug A bug to squash. labels Dec 15, 2022
Copy link
Member Author

Ok @TylerLeonhardt all done.

Copy link
Member Author

@SeeminglyScience I kind of wonder if we should just copy/paste that function without the -daily to support finding the pwsh installed by this script without the -Daily parameter...but what would we call it, "PowerShell Install Script"?

Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan deleted the andschwa/daily branch December 19, 2022 20:09
Copy link
Member Author

@TylerLeonhardt available in the preview now!

TylerLeonhardt reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't use PowerShell Daily without fully resolved path

AltStyle によって変換されたページ (->オリジナル) /