-
Notifications
You must be signed in to change notification settings - Fork 519
Make Logger.WriteLine thread-safe and fix bug with UNC paths
#4276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hence we were losing logs.
When we moved to using `globalStorageUri` and passing `vscode.Uri`s around, we did not test UNC shares. It turns out that while `vscode.Uri.fsPath`'s documentation says that it "does not look at scheme," it actually does look at the scheme and essentially requires it to be `file`. The scheme of the `globalStorageUri` however is `vscode-userdata`, so the `fsPath` fails to then handle the UNC share path. We are now replacing the scheme with `file` to get around this bug.
SeeminglyScience
SeeminglyScience
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Well done getting this figured out ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple lock to
Logger.WriteLinesince it's not re-entrant, hence we were losing logs. Now concurrent calls to it wait for each other to finish. It also should fix #4202, as the bug appears to be with the scheme used inglobalStorageUribeingvscode-userdatainstead offile, andvscode.Uri.fsPathclaiming it does not care about the scheme, but in fact essentially requires it to befile.