-
Notifications
You must be signed in to change notification settings - Fork 520
Enable strict TypeScript mode
#4206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@andyleejordan
andyleejordan
added
Issue-Enhancement
A feature request (enhancement).
Area-Engine
labels
Oct 12, 2022
@andyleejordan
andyleejordan
force-pushed
the
andschwa/strict
branch
from
October 14, 2022 23:24
3022dc5 to
a2b6a28
Compare
Hey @SeeminglyScience I did it! I hope. There was...some refactoring involved.
@andyleejordan
andyleejordan
force-pushed
the
andschwa/strict
branch
from
October 15, 2022 00:15
6c34480 to
bddc3e3
Compare
@andyleejordan
andyleejordan
force-pushed
the
andschwa/strict
branch
from
October 17, 2022 17:18
bddc3e3 to
701a510
Compare
SeeminglyScience
SeeminglyScience
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@andyleejordan
andyleejordan
force-pushed
the
andschwa/strict
branch
3 times, most recently
from
October 17, 2022 18:55
44437e4 to
b04a4d1
Compare
Was mostly whitespace 🤷
@andyleejordan
andyleejordan
force-pushed
the
andschwa/strict
branch
from
October 17, 2022 19:59
b04a4d1 to
b8189fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
So we're actually using TypeScript properly with type checking. Resolves #3561.