-
Notifications
You must be signed in to change notification settings - Fork 520
Update vscode-languageclient and refactor (a lot of TLC)
#4131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aeb44a4 to
43d054b
Compare
Also update our engine to align with ADS's update to 1.62.0. Unfortunately, we still have unresolved work pending their update to 1.65.0.
43d054b to
1d96e16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! well done 🎉
(after tests pass ofc)
0a64bf4 to
6e936f3
Compare
Lots of clean-up, a little refactoring, and most importantly, a less buggy `LanguageClient` implementation (which is less prone to race conditions). Also handle disposal of handler registrations.
It's faster...it reads better.
The last one involves a stream.
This is necessary to take the language client library update. Unfortunately it means that ADS won't be able to take the next update to our extension until they catch up to at least this engine version. It could be worse, we didn't have to bump to 1.7x.
6e936f3 to
e93425d
Compare
vscode-languageclient and refactor (削除ここまで)vscode-languageclient and refactor (a lot of TLC) (追記ここまで)
FYI @Charles-Gagnon we had to bump our engine to 1.65 in order to (finally) take the language client library update. What's ADS's ETA to merge 1.65?
Charles-Gagnon
commented
Aug 18, 2022
No exact ETA at this point in time - we're working on another update currently though (probably for October/November) that may get up that far, if not then it'll be sometime early next year.
No worries, if you need we can back-port some patches and cut you a new release, but hopefully you can just take this one sooner rather than later!
Hopefully fixes #4128 by eliminating race conditions in the
LanguageClient's connection process.