-
Notifications
You must be signed in to change notification settings - Fork 520
Rename "Integrated Console" to "Extension Terminal" #4090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Specifically we drop "Terminal" for the title in the terminals pane as that's redundant (and too long for a narrow view). We switching to "terminal" from "console" to align with VS Code's terminology, and "PowerShell Extension Terminal" is what was decided in the RFC through community feedback.
@JustinGrote did I miss anything?
@andschwa the most visible occurances of it are covered at least, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed the labels on GitHub too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You think of everything!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly no "Terminal" addendum because this is what's displayed in the list of terminals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Truly I just didn't like the ASCII arrows.
8d2cf9d to
765f658
Compare
Resolves #4053.