Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix snippet prefixes (especially #region) #3900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andyleejordan merged 1 commit into master from andschwa/snippets
Mar 31, 2022
Merged

Conversation

Copy link
Member

@andyleejordan andyleejordan commented Mar 31, 2022

The snippets' prefixes should all be consistently lower-cased, and
moreover, the region/endregion snippet must not start with a hashtag,
because this triggers the completion when users are trying to type
comments. VS Code also has two built-in snippets with this issue, that
should be removed upstream.

Coupled with microsoft/vscode#146459, this fixes #3276.

The snippets' prefixes should all be consistently lower-cased, and
moreover, the region/endregion snippet must not start with a hashtag,
because this triggers the completion when users are trying to type
comments. VS Code also has two built-in snippets with this issue, that
should be removed upstream.
Copy link
Collaborator

LGTM, probably mostly muscle memory on my part, thanks!

andyleejordan reacted with hooray emoji

@andyleejordan andyleejordan merged commit 8e4d1c0 into master Mar 31, 2022
@andyleejordan andyleejordan deleted the andschwa/snippets branch March 31, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinGrote JustinGrote JustinGrote approved these changes

@SeeminglyScience SeeminglyScience Awaiting requested review from SeeminglyScience

@SydneyhSmith SydneyhSmith Awaiting requested review from SydneyhSmith

Assignees
No one assigned
Labels
Projects
No open projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typing <-#-<RET> results in <#endregion#> instead of <#\n

AltStyle によって変換されたページ (->オリジナル) /