-
Notifications
You must be signed in to change notification settings - Fork 521
Fix Pester Test/Debug code lenses to now change directory
#3852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're passing the full path of the test file to the invocation script, so we do not need to (nor should we, as it could be difficult to workaround) change the location before running the tests. This just means not passing a value for `cwd` in the launch configuration.
Just for sanity, here's the PSES code that does not cd when cwd is null: https://github.com/PowerShell/PowerShellEditorServices/blob/f0b5b2e33c8cc3ee2f59a91129438655101b9401/src/PowerShellEditorServices/Services/DebugAdapter/Handlers/LaunchAndAttachHandler.cs#L159-L168
SeeminglyScience
SeeminglyScience
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're passing the full path of the test file to the invocation script,
so we do not need to (nor should we, as it could be difficult to
workaround) change the location before running the tests. This just
means not passing a value for
cwdin the launch configuration.Fixes #3259.