-
Notifications
You must be signed in to change notification settings - Fork 519
Fix base URI for PSScriptAnalyzer rule documentation #3608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andyleejordan
merged 1 commit into
PowerShell:master
from
bgold09:dev/bgold09/fix/ruleDocumenationUri
Oct 8, 2021
Merged
Fix base URI for PSScriptAnalyzer rule documentation #3608
andyleejordan
merged 1 commit into
PowerShell:master
from
bgold09:dev/bgold09/fix/ruleDocumenationUri
Oct 8, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@andyleejordan
andyleejordan
added
Area-Script Analysis
Issue-Bug
A bug to squash.
labels
Oct 8, 2021
@andyleejordan
andyleejordan
changed the title
(削除) Fix base URI for rule documentation (削除ここまで)
(追記) Fix base URI for PSScriptAnalyzer rule documentation (追記ここまで)
Oct 8, 2021
andyleejordan
andyleejordan
approved these changes
Oct 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fix, thank you so much!
4 tasks
2 tasks
@andschwa no problem, it was an easy fix 😄
SyfiMeal
added a commit
to SyfiMeal/vscode-powershell
that referenced
this pull request
Oct 23, 2021
This reverts commit 8f40aa1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Summary
PR PowerShell/PSScriptAnalyzer#1724 moved all documentation to a new
directory in the repo. Therefore when a rule violation is detected in
the editor and a user uses the code action to navigate to the rule's
documentation, they are brought to an invalid URI.
Fixing the base URI to rule documentation in the PSScriptAnalyzer repo.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.