Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow PowerShell session to start and stop the debugger interface #3542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andyleejordan merged 2 commits into master from andschwa/stop-debugger
Sep 7, 2021

Conversation

Copy link
Member

@andyleejordan andyleejordan commented Sep 2, 2021
edited
Loading

Used to indicate the PowerShell debugger has stopped and so the connected debugger interface in the extension should also stop (as in detach and quit, not break). Along with PowerShell/PowerShellEditorServices#1570, resolves #3522.

Just invoke the clean task first if you want to rebuild
PowerShellEditorServices. Also put `problemMatcher` back into the tasks
so as to stop Visual Studio Code from asking the user which to use.
Used to indicate the PowerShell debugger has stopped and so the
connected debugger interface in the extension should also stop (as in
detach and quit, not break).
@ghost ghost added Area-Debugging Issue-Discussion Let's talk about it. labels Sep 2, 2021
@andyleejordan andyleejordan marked this pull request as ready for review September 2, 2021 22:11
@andyleejordan andyleejordan changed the title (削除) Add stopDebugger notification (削除ここまで) (追記) Allow PowerShell session to start and stop the debugger interface (追記ここまで) Sep 2, 2021
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member Author

Also merging to as to test it in preview...

@andyleejordan andyleejordan merged commit 84c6300 into master Sep 7, 2021
@andyleejordan andyleejordan deleted the andschwa/stop-debugger branch September 7, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

@rjmholt rjmholt Awaiting requested review from rjmholt

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debugger Issues

AltStyle によって変換されたページ (->オリジナル) /