Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update extension icon (and use a special preview icon) #3493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andyleejordan merged 1 commit into master from andschwa/icons
Aug 3, 2021

Conversation

Copy link
Member

@andyleejordan andyleejordan commented Aug 3, 2021

This aligns us with the icons used for PowerShell 7 and sufficiently
differentiates the PowerShell, PowerShell Preview, and Azure PowerShell
extensions on the marketplace.

Resolves #3422.

This aligns us with the icons used for PowerShell 7 and sufficiently
differentiates the PowerShell, PowerShell Preview, and Azure PowerShell
extensions on the marketplace.
@ghost ghost added Area-UI Issue-Enhancement A feature request (enhancement). labels Aug 3, 2021
Copy link
Member Author

@rjmholt do you have a way to test this? It seems like since the extensions already exist on the marketplace, at least on my Mac when I build and install the VSIX I see the old icon, but I check the package contents and manifest and they're correct. I also verified and like the Python extension's icon isn't square and is ~600 pixels wide PNG so the icon itself should be fine.

Copy link
Contributor

rjmholt commented Aug 3, 2021

@rjmholt do you have a way to test this?

No, but I think it should be ok

andyleejordan reacted with thumbs up emoji

@andyleejordan andyleejordan merged commit 9709a75 into master Aug 3, 2021
@andyleejordan andyleejordan deleted the andschwa/icons branch August 3, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Area-UI Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Preview" indicator to Preview extension's marketplace icon

AltStyle によって変換されたページ (->オリジナル) /