Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

use PSGet v3 #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TylerLeonhardt wants to merge 7 commits into master from move-to-psget-3
Closed

use PSGet v3 #2932

TylerLeonhardt wants to merge 7 commits into master from move-to-psget-3

Conversation

Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Sep 2, 2020

This moves us to use the latest preview of PowerShellGet v3 and the compat PSGet module

Copy link
Member Author

:(

image

SydneyhSmith reacted with thumbs down emoji

Copy link
Member Author

TylerLeonhardt commented Sep 2, 2020
edited
Loading

(削除) I added a Get-Module and gmo -list PSGet as a way to make sure the compat module works. Is this the best way? (削除ここまで)

Ah I see, it gives a warning, nice:

image

but also :( for the error. @JamesWTruher?

Copy link
Member

I like to run (get-command find-module).module.modulebase to make sure the module that's actually loaded is the right one.

TylerLeonhardt reacted with thumbs up emoji

Copy link
Member Author

@alerickson Good to know!

Copy link
Member

alerickson commented Sep 2, 2020
edited
Loading

I guess in this context it might make more sense to run ((get-command find-module).module).Version

Copy link
Member Author

This is an odd error to me. Why is it spelled "Powershell" in the path?

Copy link
Member

alerickson commented Sep 2, 2020
edited
Loading

Okay, just updating with convo Tyler and I had offline: beta9 is the latest psget release that handles some unix path changes, there is however, a bug with the -debug param in Install/Save (I realize it's not being used right now, just a warning)

rjmholt and TylerLeonhardt reacted with thumbs up emoji

- pwsh: |
Install-Module -Scope CurrentUser -Force -AllowPrerelease PowerShellGet
Install-Module -Scope CurrentUser -Force -AllowPrerelease CompatPowerShellGet
Install-Module -Scope CurrentUser -Force -AllowPrerelease -AllowClobber PowerShellGet
Copy link
Member

@alerickson alerickson Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need -AllowClobber for PSGet since it's entirely new cmdlet names

Copy link
Member Author

@TylerLeonhardt TylerLeonhardt Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll scale better once PSGet v3 ships with PowerShell.

Copy link
Member Author

ok I'm gonna stop here for now. Looks like we have some more work:

  1. PSGallery version problem (beta10 is being treated as the version between beta1 and beta2 instead of after beta9)
  2. PSGet doesn't register PSGallery by default (forcing me to run Register-PSResourceRepository -PSGallery)
  3. Looks like either the compat module or the main module are prompting for something even though I specified -Force
rjmholt reacted with confused emoji

Copy link
Contributor

PSGet doesn't register PSGallery by default (forcing me to run Register-PSResourceRepository -PSGallery)

Surely that's a bug, right? I know, don't call you Shirley.

Copy link
Member Author

@rkeithhill personally I agree with you. I think PSGet v3 should register PSGallery by default. I only did it in the commit to see what would happen if it was already registered.

rkeithhill reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

2 more reviewers

@rjmholt rjmholt rjmholt approved these changes

@alerickson alerickson alerickson approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /