Support Untitled files and automatic *.Notebook.ps1 files #2919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

TylerLeonhardt merged 1 commit into PowerShell:master from TylerLeonhardt:improve-notebook-mode

Sep 8, 2020

Merged

Support Untitled files and automatic *.Notebook.ps1 files #2919

TylerLeonhardt merged 1 commit into PowerShell:master from TylerLeonhardt:improve-notebook-mode

Sep 8, 2020

Conversation

TylerLeonhardt

Copy link

Member

@TylerLeonhardt TylerLeonhardt commented Aug 27, 2020

PR Summary

Fixes #2866
Fixes #2901
Fixes #2865

This enables the following features:

Untitled file support - now you can open untitled PowerShell files in Notebook mode, when you save the untitled notebook the experience is what you expect (saves to ps1 and opens that ps1 in notebook mode)
Automatic Notebooks - if you create a file with *.Notebook.ps1, it will automatically open in Notebook mode. In order to do this, I needed to register 2 different viewTypes with the same underlying implementation. It's a little clunky from the dev experience (I'll probably open an issue) but the UX feels nice. You can still go back to text editor mode from a *.Notebook.ps1 if you want

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

PR has a meaningful title
Summarized changes
PR has tests
This PR is ready to merge and is not work in progress
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready