-
Notifications
You must be signed in to change notification settings - Fork 519
Fix migration of codeFormatting.addWhitespaceAroundPipe setting
#2863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix migration of codeFormatting.addWhitespaceAroundPipe setting
#2863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was quite busy the last days, thanks for fixing it. You're right with this PR, I should've used the ConfigurationTarget of the old setting as a target for the new one. When I was testing it, the debug instance of VS-Code did not have a workspace open with .vscode folder, hence why I did not notice this when testing.
No worries!
PR Summary
Fixes #2842
This will properly migrate
codeFormatting.whitespaceAroundPipetocodeFormatting.addWhitespaceAroundPipe.Also, the saving of file triggered the
this.languageClientto cause a warning to show because PSES wasn't finished initializing so I've just swapped the conditional now. Later I could do something different (like athis.isLanguageClientConnectedbut I'll defer that)PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready