Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Removes Broken "Run Pester Tests" from the Command Pallette #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SydneyhSmith wants to merge 3 commits into PowerShell:master from SydneyhSmith:master

Conversation

Copy link
Collaborator

@SydneyhSmith SydneyhSmith commented May 29, 2020

PR Summary

Fixes #2715

Removes "PowerShell.RunPesterTestsFromFile" and "PowerShell.DebugPesterTestsFromFile" from the command pallette since they do not work, and are tasks that can effectively be run in other ways.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • [NA] PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@ghost ghost added Area-Pester Issue-Bug A bug to squash. labels May 29, 2020
Copy link
Member

TylerLeonhardt commented May 30, 2020
edited
Loading

This is not quite what we want. Since this is in the "explorer/context": [ section, that controls the what shows in the context menu when you right click on file in the explorer pane (to see what I've talking about, right click on a foo.Tests.ps1 file)

image

What we want is two new entries under "commandPalette": [ which is right above "explorer/context": [

Copy link
Member

Also don't worry about the test failures... that's because of the Omnisharp issue.

Copy link
Member

I accidentally fixed this allowing the command palette to work so we don't need this 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerLeonhardt TylerLeonhardt Awaiting requested review from TylerLeonhardt

@rjmholt rjmholt Awaiting requested review from rjmholt

Assignees
No one assigned
Labels
Area-Pester Issue-Bug A bug to squash.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Run Pester Tests" results in Running ... 'Powershell.RunPesterTestsFromFile' failed

AltStyle によって変換されたページ (->オリジナル) /