-
Notifications
You must be signed in to change notification settings - Fork 520
(GH-1336) Add syntax aware folding provider #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e50704e
09c8ade
f5ee6d2
1e15180
6a99426
0434ff8
5156173
d9a9e6d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ | |
| "publisher": "ms-vscode", | ||
| "description": "Develop PowerShell scripts in Visual Studio Code!", | ||
| "engines": { | ||
| "vscode": "^1.22.0" | ||
| "vscode": "^1.23.0" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the version increment required for this PR? I don't think we have a particular policy, but dependency version changes are important enough that it would be worth considering having that as its own PR. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. The Folding API only exists in 1.23.0+ There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, I'm convinced 😄 @tylerl0706 Maybe we should consider this a policy for the future, especially with all the feature work going into VSCode — I know .NET Core's latest update was surprisingly tricky for PowerShell. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess we could. We haven't gotten burned by it yet AFAIK but it doesn't hurt. Next time :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Next time was last time :-P |
||
| }, | ||
| "license": "SEE LICENSE IN LICENSE.txt", | ||
| "homepage": "https://github.com/PowerShell/vscode-powershell/blob/master/README.md", | ||
|
|
@@ -52,7 +52,7 @@ | |
| "vscode.powershell" | ||
| ], | ||
| "scripts": { | ||
| "compile": "tsc -v && tsc -p ./ && tslint -p ./ -e test/*", | ||
| "compile": "tsc -v && tsc -p ./ && tslint -p ./", | ||
| "compile-watch": "tsc -watch -p ./", | ||
| "postinstall": "node ./node_modules/vscode/bin/install", | ||
| "test": "node ./node_modules/vscode/bin/test" | ||
|
|
@@ -467,6 +467,11 @@ | |
| "default": "", | ||
| "description": "Specifies the path to a PowerShell Script Analyzer settings file. To override the default settings for all projects, enter an absolute path, or enter a path relative to your workspace." | ||
| }, | ||
| "powershell.codeFolding.enable": { | ||
| "type": "boolean", | ||
| "default": true, | ||
| "description": "Enables syntax based code folding. When disabled, the default indentation based code folding is used." | ||
| }, | ||
| "powershell.codeFormatting.preset": { | ||
| "type": "string", | ||
| "enum": [ | ||
|
|
||