Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Enhanced Logging #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andyleejordan merged 8 commits into main from feature/logImprovements
Nov 15, 2024
Merged

Enhanced Logging #2200

andyleejordan merged 8 commits into main from feature/logImprovements
Nov 15, 2024

Conversation

Copy link
Collaborator

@JustinGrote JustinGrote commented Nov 15, 2024
edited
Loading

  • Align PsesLogLevel to MEL log levels
  • Adjust some logging verbosity levels for the PSES startup logging flow to move better.
  • Create a new LSP Log Debug Provider to get around limitations with the CSharp Omnisharp one.
  • Drop all Omnisharp logs to trace since they are just LSP related
  • Address LSP bugs by wiring up log levels in-band.

Should be merged with PowerShell/vscode-powershell#5065

@JustinGrote JustinGrote requested a review from a team as a code owner November 15, 2024 04:24
@JustinGrote JustinGrote marked this pull request as draft November 15, 2024 04:24
@JustinGrote JustinGrote changed the title (削除) Enhance logging configuration and levels (削除ここまで) (追記) Enhanced Logging (追記ここまで) Nov 15, 2024
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you want to get this into the upcoming preview?

JustinGrote reacted with thumbs up emoji
@andyleejordan andyleejordan merged commit 9ce8911 into main Nov 15, 2024
8 checks passed
@andyleejordan andyleejordan deleted the feature/logImprovements branch November 15, 2024 21:55
@andyleejordan andyleejordan added the Issue-Enhancement A feature request (enhancement). label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

@SeeminglyScience SeeminglyScience Awaiting requested review from SeeminglyScience

Labels
Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /