This repository was archived by the owner on May 11, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 812
fix: correct method name in get_events (closes AttributeError)#224
Open
Sertug17 wants to merge 1 commit into
Open
fix: correct method name in get_events (closes AttributeError) #224Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
get_events called self.parse_event() which does not exist on GammaMarketClient. The correct method is self.parse_pydantic_event(). This caused a runtime AttributeError when parse_pydantic=True.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to Polymarket Agents. Thank you for creating your first PR. Cheers!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Problem
get_events()callsself.parse_event()on line 115, but this methoddoes not exist on
GammaMarketClient. The correct method name isself.parse_pydantic_event().This causes a runtime
AttributeErrorwheneverget_events()is calledwith
parse_pydantic=True.Fix
Replace
self.parse_event(market_event_obj)withself.parse_pydantic_event(market_event_obj)on line 115.Reproduction
Note
Low Risk
Low risk one-line bugfix that only changes which method is invoked when
parse_pydantic=True, preventing a runtimeAttributeError. Behavior remains the same aside from correctly returning parsedPolymarketEventobjects instead of crashing.Overview
Fixes
GammaMarketClient.get_events(parse_pydantic=True)by callingparse_pydantic_event()instead of a non-existentparse_event()method, eliminating a runtimeAttributeErrorand restoring pydantic parsing for/eventsresponses.Reviewed by Cursor Bugbot for commit 0ee83b1. Bugbot is set up for automated code reviews on this repo. Configure here.