Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix Implicitly marking parameter $maxItems as nullable is deprecated #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhrozenByte merged 3 commits into PhrozenByte:master from bytestream:patch-1
Sep 24, 2025

Conversation

Copy link
Contributor

@bytestream bytestream commented Sep 24, 2025 •
edited
Loading 

PHP Deprecated: PhrozenByte\PHPUnitArrayAsserts\ArrayAssertsTrait::assertSequentialArray(): Implicitly marking parameter $maxItems as nullable is deprecated, the explicit nullable type must be used instead in /vendor/phrozenbyte/phpunit-array-asserts/src/ArrayAssertsTrait.php on line 158
PHP Deprecated: PhrozenByte\PHPUnitArrayAsserts\ArrayAssertsTrait::sequentialArray(): Implicitly marking parameter $maxItems as nullable is deprecated, the explicit nullable type must be used instead in /vendor/phrozenbyte/phpunit-array-asserts/src/ArrayAssertsTrait.php on line 186

@PhrozenByte PhrozenByte merged commit f21a111 into PhrozenByte:master Sep 24, 2025
24 checks passed
@bytestream bytestream deleted the patch-1 branch September 24, 2025 16:24
Copy link
Owner

PhrozenByte commented Sep 24, 2025 •
edited
Loading

Thanks! ❤️

I just additionally updated the CI to check up to PHP 8.4 and fixed the same deprecation notices in the test suite. Unfortunately the same deprecations also affect Psalm 4 which therefore doesn't work with PHP 8.4. So, no static code analysis for PHP 8.4... 😒 See #2 for details. Help is very welcome (like any other PR, too, btw).

I just pushed a new tag for both phpunit-array-asserts and phpunit-throwable-asserts. Please go ahead and report any issues 👍 Fun fact: Since I tagged your squashed commit GitHub shows that you tagged that release 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /