-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Gradle plugin update to 7.2 #5302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated gradle plugin and dependencies. Updated the target SDK. Fixed a lint error. Fixed javadoc classpath error.
hannesa2
commented
Jun 20, 2022
Sadly this repo is dead and I helped myself https://github.com/AppDevNext/MPAndroidChart/blob/master/gradle/wrapper/gradle-wrapper.properties
Please see #5268
dizcza
commented
Nov 2, 2022
@hannesa2 I started using your fork before realizing you have no way to interact with the users save for this dead repo.
Firstly, the touches do NOT work on your fork. They do work here.
Secondly, unless you made the issues page open, others will not use it.
Silly I'm complaining about issues in a dead thread, in the wrong place...
hannesa2
commented
Nov 2, 2022
@dizcza Indeed the issues tab was missing. I guess it's the default behavior of a fork. -I changed it-
the touches do NOT work on your fork.
I've no clue, what you are speaking about
Btw, please consider to improve your communication skills. Instead of complaining about something, why something does not work for you, you can make suggestion to improve the situation.
dizcza
commented
Nov 2, 2022
@hannesa2 don't take it personal
that was me who I made fun of for being silly
Touches callbacks issue: have a look at https://github.com/dizcza/MagneticViewer/blob/master/app/src/main/java/ua/dronesapper/magviewer/SensorLineChart.kt
the touch callbacks are not executed in your fork. So I switched back to the original repo.
hannesa2
commented
Jan 5, 2023
Touches callbacks issue: have a look at https://github.com/dizcza/MagneticViewer/blob/master/app/src/main/java/ua/dronesapper/magviewer/SensorLineChart.kt
@dizcza The link is dead
Touches callbacks issue: have a look at https://github.com/dizcza/MagneticViewer/blob/master/app/src/main/java/ua/dronesapper/magviewer/SensorLineChart.kt
@dizcza The link is dead
It's moved to https://github.com/dizcza/TcpDataViewer/blob/master/app/src/main/java/ua/dronesapper/tcpdataviewer/SensorLineChart.kt
Let me know if you're working on it. I may switch to your fork and test once it's fixed.
Update Jan 07, 2022
The touches issue is fixed in the fork branch.
PR Checklist:
PR Description
This change makes the library compatible with the latest gradle plugin and Android Studio.
The change also updates library dependencies and fixes minor issues related to using deprecated APIs.
It also provides a fix to a minor lint error in the libary example.
It fixes javadoc classpath error.