-
Notifications
You must be signed in to change notification settings - Fork 26
Comments
Conversation
t/coretests.pm
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these need to be changed, and to be honest the old version is technically the more correct one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restored the previous version via 4948177
t/coretests.pm
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is indented incorrectly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed via 590c618... unfortunately the whole indentation of this file is a mess... mixing spaces and tabs...
restored the "\t\s+" indentation used around the other lines to match
590c618 to
4948177
Compare
Leont
commented
Sep 23, 2020
Could you please change the ->can calls back to symbolic references? As we're dealing with functions here and not methods, the former seem more appropriate (and I can live with 'no strict refs' here)
4948177 to
f15ac5f
Compare
atoomic
commented
Sep 23, 2020
@Leont I removed the ->can and add a few no strict 'refs' to preserve symbolic references.
I'm not sure what was wrong about using can on %main::
haarg
commented
Sep 23, 2020
can is for finding methods and checks the inheritance chain. The subs being used in the tests are not methods, they are functions. While it's unlikely that main will have any parent classes (aside from UNIVERSAL and anything added to @UNIVERSAL::ISA), it's still more correct to check for the sub directly.
Leont
commented
Apr 28, 2024
This branch doesn't seem to apply anymore.
No description provided.