forked from Yandex-Practicum/Java-Module-Project-YP
-
Notifications
You must be signed in to change notification settings - Fork 0
Comments
Open
Conversation
AleksandrIlinskii
commented
Dec 14, 2023
Привет Павел! Ты молодец, создал свое первое приложение! А теперь непосредственно к ревью
double productCost = 0.0;// цена продукта
int persons = 2;// минимальное значение, чтобы метод работал
double finalResult = 0.2f;// заплатит каждый с округлением до 2х чисел после точки
void calculate() {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Перед методом обычно оставляют пустую строку, чтобы логически их разделить
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это все лишние пустые строки
AleksandrIlinskii
commented
Dec 14, 2023
Критический баг No1
image
Приложение крашится, если вместо количества человек ввести буквы
AleksandrIlinskii
commented
Dec 14, 2023
Критический баг No2
image
Приложение крашится, если вместо цены ввести буквы
AleksandrIlinskii
commented
Dec 14, 2023
Критический баг No3
image
Если ввести любое количество людей - он все равно делит на 2
AleksandrIlinskii
commented
Dec 14, 2023
Критический баг No4
image
Окончание слова "рубль" неверно
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Пару недель назад узнал что такое переменные, а теперь удалось создать свое первое консольное приложение. Это было не просто...