-
Notifications
You must be signed in to change notification settings - Fork 87
Comments
Conversation
A link with target=_blank was not opening in a new tab.
tugceakin
commented
Dec 1, 2020
@Paratron Could you review the PR?
Paratron
commented
Dec 1, 2020
Merged! Interesting that no one catched this before :D
Thanks for the fix :)
tugceakin
commented
Dec 1, 2020
Thank you 🙏
ogazitt
commented
Dec 21, 2020
This commit introduces a syntax error (two close parens) on line Link.js:22.
A previous commit (linked to Paratron#146) inserted an extra ')' to close the if statement, leading to a syntax error. This very simple commit fixes it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tugceakin Seems like you accidentally added an extra closing parantheses here ).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ogazitt Sorry I should have looked around. I only noticed it when i was fixing my issue with the ForwardRefs in Material UI.
Expected
target=_blankattribute opens the linked document in a new window or tabActual
target=_blankdoesn't change the behavior of the link.