-
-
Notifications
You must be signed in to change notification settings - Fork 167
chore: Upgrade to JasperStarter 3.6.2 #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade to JasperStarter 3.6.2 #311
Conversation
57ae498 to
9fdd400
Compare
@geekcom Can you please review this PR?
@vitormattos Hi Vitor, can you please review this pull-request?
lucasctd
commented
May 3, 2022
@leandrocopam may you?
Thx XD
yvescleuder
commented
Jun 15, 2022
Hi,
How do I install this dependency from your project? I need the new version of JasperStartwe, when I try to install by composer using this:
image
It generates an error informing me that the PHPJasper class does not exist.
"message": "Class "PHPJasper\PHPJasper" not found"
If install from compose require geekcom/phpjasper is it worked... more new version
Is too hardy to do this review, have a lot of files.
I think that binary files can't stay in the repository, maybe will be best to move all binaries to other repository and use require to use the external repository or use other approach using environments or other way to define the version/tag of dependencies.
Following with these binaries in this repository also will be very hard to clone and work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the relation of bumb version and change the EOL char?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original files have CRLF as the EOL, but git was changing to LF.
Added to .gitattributes to keep them without changes to EOL.
@vitormattos Including the binary dependencies directly in this repo has the advantage of knowing PHPJasper will work after install, without issues.
9fdd400 to
ebc8363
Compare
Hi @Xint0-elab, this PR is tested?
Hi @Xint0-elab, this PR is tested?
Yes, I used my fork in production. But have since switched to using https://github.com/smart145/phpjasper.
Uh oh!
There was an error while loading. Please reload this page.
Upgrade JasperStarter to version 3.6.2
@geekcom Can you please review?