Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: Upgrade to JasperStarter 3.6.2 #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Xint0-elab wants to merge 4 commits into PHPJasper:master
base: master
Choose a base branch
Loading
from Xint0-elab:Upgrade_to_JasperStarter_3.6.2

Conversation

Copy link

@Xint0-elab Xint0-elab commented Feb 21, 2022
edited
Loading

Upgrade JasperStarter to version 3.6.2

@geekcom Can you please review?

SIC-DavideLocatelli and lucasctd reacted with thumbs up emoji
Copy link
Author

@geekcom Can you please review this PR?

Copy link
Author

@vitormattos Hi Vitor, can you please review this pull-request?

Copy link

lucasctd commented May 3, 2022

@leandrocopam may you?
Thx XD

Copy link

Hi,
How do I install this dependency from your project? I need the new version of JasperStartwe, when I try to install by composer using this:
image
It generates an error informing me that the PHPJasper class does not exist.
"message": "Class "PHPJasper\PHPJasper" not found"

If install from compose require geekcom/phpjasper is it worked... more new version

Copy link
Member

Is too hardy to do this review, have a lot of files.

I think that binary files can't stay in the repository, maybe will be best to move all binaries to other repository and use require to use the external repository or use other approach using environments or other way to define the version/tag of dependencies.

Following with these binaries in this repository also will be very hard to clone and work.

Comment on lines +1 to +5
CHANGES text eol=crlf
LICENSE text eol=crlf
NOTICE text eol=crlf
README.md text eol=crlf
jdbc/README text eol=crlf
Copy link
Member

@vitormattos vitormattos Jun 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the relation of bumb version and change the EOL char?

Copy link
Author

@Xint0-elab Xint0-elab Jun 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original files have CRLF as the EOL, but git was changing to LF.

Added to .gitattributes to keep them without changes to EOL.

Copy link
Author

@vitormattos Including the binary dependencies directly in this repo has the advantage of knowing PHPJasper will work after install, without issues.

Copy link
Member

geekcom commented Oct 2, 2023

Hi @Xint0-elab, this PR is tested?

Copy link
Author

Hi @Xint0-elab, this PR is tested?

Yes, I used my fork in production. But have since switched to using https://github.com/smart145/phpjasper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitormattos vitormattos vitormattos left review comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /