-
Notifications
You must be signed in to change notification settings - Fork 7
Comments
Make the putS3ObjectRequest public to allow for further customization#1
Open
gabceb wants to merge 2 commits intoOpenWatch:master from
Open
Make the putS3ObjectRequest public to allow for further customization #1gabceb wants to merge 2 commits intoOpenWatch:master from
gabceb wants to merge 2 commits intoOpenWatch:master from
Conversation
... of the S3 request's headers and parameters
Member
chrisballinger
commented
Jun 1, 2014
I think I'm going to deprecate this library in favor of Amazon's official S3TransferManager. Thanks for the contribution though!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code does not allow for further customization such as content-type, content-encoding.
Instead of adding more methods so these properties can be changed, the visibility of the putS3ObjectRequest method can be changed to public so the customization can be done by the developer and pass the request down to the library.