Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Virtual debit card #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Contributor

@viditvarshney viditvarshney commented Aug 31, 2018

THis is a web based project , this code generates a virtual debit card with name of yours and a CVV number on it ... the best part of this is .. CVV number changes every time when you run the code

viditvarshney and theamanbhargava reacted with thumbs up emoji
Copy link

@divyanshu-rawat divyanshu-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor Author

viditvarshney commented Sep 1, 2018 via email

...
On Sat, Sep 1, 2018, 3:19 PM Divyanshu Rawat ***@***.***> wrote: ***@***.**** approved this pull request. LGTM! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#18 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Agk8ZSPZfcfAicK0gIQEvTUWHo0bSay6ks5uWlgbgaJpZM4WVn1n> .

Copy link

divyanshu-rawat commented Sep 1, 2018
edited
Loading

@Paarmita
can you please review it 👍

Copy link
Contributor Author

excuse me why my code is not merged yet?

Copy link

@viditvarshney I have reviewed your code and it looks good to me, but it doesn't mean that it looks good to other contributors and community members as well.
So, I am waiting for other community members to review it as well.
Good Luck 👍

@yashovardhanagrawal, can you go through the code and review and see whether it's good to merge. 👍

Copy link
Collaborator

Looks good to me too.

divyanshu-rawat reacted with thumbs up emoji

Copy link
Contributor

@sunilsj99 sunilsj99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me as well !!

@theamanbhargava theamanbhargava merged commit 8fb69b0 into OpenSouce-LNMIIT:master Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashovardhan yashovardhan Awaiting requested review from yashovardhan

2 more reviewers

@divyanshu-rawat divyanshu-rawat divyanshu-rawat approved these changes

@sunilsj99 sunilsj99 sunilsj99 approved these changes

Reviewers whose approvals may not affect merge requirements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /