-
Notifications
You must be signed in to change notification settings - Fork 1
ci: fix SonarCloud S8549 in cross-platform and MSRV workflows - #272
Draft
cursor[bot] wants to merge 1 commit into
Draft
ci: fix SonarCloud S8549 in cross-platform and MSRV workflows #272cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
SonarCloud githubactions:S8549 flags cargo build without lockfile enforcement. Generate Cargo.lock in CI and pass --locked so dependency versions cannot drift silently during the build step. Co-authored-by: Alexander Wagner <info@alexanderwagnerdev.com>
Important
Review skipped
Bot user detected.
To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 3b037f7f-29cc-4508-8aa1-3d6b655c0097
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
- 🔍 Trigger review
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Quality Gate Passed Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes SonarCloud quality gate failure on PR #271 (
new_security_ratingdropped to C).SonarCloud rule
githubactions:S8549flaggedcargo buildsteps in the new cross-platform and MSRV workflows for not enforcing locked dependency versions.Changes
Cargo.lockin CI viacargo generate-lockfilebefore builds--lockedto allcargo buildinvocations in.github/workflows/cross-platform.ymland.github/workflows/msrv.ymlTesting
CI should re-run SonarCloud analysis and clear the four
githubactions:S8549findings.