-
Notifications
You must be signed in to change notification settings - Fork 120
Open
Conversation
documentElement.lang only mapped pt->pt-BR and fell back to en, mispronouncing es/fr/de/zh/ja/ko/ru in screen readers (WCAG 3.1.1). Map every InterfaceLocale to BCP-47 (zh->zh-CN) and only write when changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
documentElement.lang only mapped pt->pt-BR and fell back to en, so screen readers mispronounced es/fr/de/zh/ja/ko/ru (WCAG 3.1.1 Language of Page).
This maps every InterfaceLocale to BCP-47 (pt->pt-BR, zh->zh-CN, rest as-is) and only writes when changed to avoid extra renders.
Verified: npm test 105/105 passing, map covers all 9 locales.