Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings
This repository was archived by the owner on May 18, 2019. It is now read-only.

[BE] Added usage of failtrace debug flag#2357

Open
kabdelhak wants to merge 1 commit into
OpenModelica:master from
kabdelhak:failtrace
Open

[BE] Added usage of failtrace debug flag #2357
kabdelhak wants to merge 1 commit into
OpenModelica:master from
kabdelhak:failtrace

Conversation

@kabdelhak

@kabdelhak kabdelhak commented Apr 11, 2018

Copy link
Copy Markdown
Contributor
  • BackendEquation.solveEquation

CLAassistant commented Apr 11, 2018 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Member

The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2018年04月11日_18-16-17.

lochel commented May 8, 2018

Copy link
Copy Markdown
Member

Welcome @kabdelhak. Thanks for your first contribution.
Why do you want to hide the error message? Is the function supposed to fail and the test suite doesn't cover that case?

kabdelhak commented May 8, 2018 via email

Copy link
Copy Markdown
Contributor Author
Thank you, the commit was manly for me to get to used to the whole GIT-process. I stumpled upon it and asked Willi Braun about what that might be and we figured, that the function is allowed to fail and is not a crucial error. We thought it should just be shown if explicitly asked for. Am 08.05.18 12:55 schrieb Lennart Ochel <notifications@github.com>:
...
Welcome @kabdelhak(https://github.com/kabdelhak). Thanks for your first contribution. Why do you want to hide the error message? Is the function supposed to fail and the test suite doesn't cover that case? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub(#2357 (comment)), or mute the thread(https://github.com/notifications/unsubscribe-auth/AkRS_UoyP5cauOFho0Jx-He6e-9YEuvnks5twXmzgaJpZM4TQMiW).

lochel commented May 14, 2018

Copy link
Copy Markdown
Member

@kabdelhak, @wibraun Do you have a model where this function actually fails? It should obviously fail for algorithms, when equations, and if equations. However, if it is not expected to reach one of these cases, then I would rather keep the error message explicit.

wibraun commented May 14, 2018

Copy link
Copy Markdown
Member

@lochel It depends on the usage of this function. If one would like to use it as a try and in failing case do something else, than the error message is totally misleading, especially for end-users. So I think it's okay to hide it. In the new removeSimpleEquations module is used like that and therefore I proposed to hide the error messages instead of having them in all related tests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /