-
Notifications
You must be signed in to change notification settings - Fork 61
Conversation
OpenModelica-Hudson
commented
Oct 7, 2016
The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2016年10月07日_08-16-20.
56502c6 to
3879132
Compare
OpenModelica-Hudson
commented
Oct 2, 2017
The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2017年10月02日_11-49-39.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a bit strange. The if condition will always fail since fmi2callbacksOK is set to 1 unless you are doing something in MMC_CATCH_INTERNAL which is of course not the case since fmi2callbacksOK is local.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not weird. It's setjmp/longjmp. The assignment to fmi2callbacksOK doesn't occur if an error is triggered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, it's a bit wrong since it returns before restoring the jump buffer. But a bigger problem is that when OM imports the FMU, we use thread-local storage for the threadData and we need to have separate threadData for the importing model... This seems to be what causes the crashes. Maybe we need to make the simulation check for existing threadData and re-use that...
3879132 to
18ed650
Compare
No description provided.