Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Rory instrumentation #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rorymckinley wants to merge 4 commits into main
base: main
Choose a base branch
Loading
from rory-instrumentation
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/ws-worker/src/api/claim.ts
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,12 @@ const claim = (
delete app.openClaims[claimId];
logger.error('TIMEOUT on claim. Runs may be lost.');
reject(new Error('timeout'));
})
.receive('*', (response) => {
delete app.openClaims[claimId];
logger.error(`[Claim ${claimId}] Received UNEXPECTED response status. Full response:`, JSON.stringify(response, null, 2));
logger.error(`[Claim ${claimId}] Channel state:`, app.queueChannel?.state);
reject(new Error('unexpected response status'));
});
});
};
Expand Down
7 changes: 7 additions & 0 deletions packages/ws-worker/src/channels/worker-queue.ts
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,13 @@ const connectToWorkerQueue = (
// if we fail to connect, the socket will try to reconnect
// forever (?) with backoff - see reconnectAfterMs
socket.onError((e: any) => {
logger.error('Socket error event:', e);
logger.error('Socket error type:', typeof e);
logger.error('Socket error details:', {
message: e?.message,
code: e?.code,
reason: e?.reason,
});
Sentry.addBreadcrumb({
category: 'lifecycle',
message: 'Error in web socket connection',
Expand Down
61 changes: 61 additions & 0 deletions packages/ws-worker/src/server.ts
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,67 @@ function connect(app: ServerApp, logger: Logger, options: ServerOptions = {}) {
app.socket = socket;
app.queueChannel = channel;

// Intercept raw channel messages to see what Lightning is sending
const originalOnMessage = channel.onMessage.bind(channel);
channel.onMessage = function(event, payload, ref) {
logger.debug('─────────────────────────────────────');
logger.debug('[Channel onMessage] Received raw message');
logger.debug('[Channel onMessage] Event:', event);
logger.debug('[Channel onMessage] Payload:', JSON.stringify(payload, null, 2));
logger.debug('[Channel onMessage] Ref:', ref);
logger.debug('[Channel onMessage] Channel state before processing:', channel.state);
logger.debug('─────────────────────────────────────');

const result = originalOnMessage(event, payload, ref);

logger.debug('[Channel onMessage] After processing, channel state:', channel.state);

return result;
};

// Add channel event listeners for debugging
channel.onError((error) => {
logger.error('Channel error event (raw):', error);
logger.error('Channel error type:', typeof error);
logger.error('Channel error constructor:', error?.constructor?.name);
logger.error('Channel error keys:', Object.keys(error || {}));
logger.error('Channel error stringified:', JSON.stringify(error, null, 2));
// Try to extract common error properties
if (error) {
logger.error('Error details:', {
message: error.message,
reason: error.reason,
response: error.response,
status: error.status,
stack: error.stack,
});
}
logger.error('Channel state:', channel.state);
logger.error('Open claims:', Object.keys(app.openClaims));
});

channel.onClose((event) => {
logger.error('Channel close event:', event);
logger.error('Channel state:', channel.state);
logger.error('Open claims:', Object.keys(app.openClaims));
});
logger.debug('Channel event listeners attached (onError, onClose)');

// Wrap the channel's push method to log all WebSocket messages (Patch 5)
const originalPush = channel.push.bind(channel);
channel.push = function(event, payload) {
logger.debug('[Channel Push] Event:', event);
logger.debug('[Channel Push] Payload:', JSON.stringify(payload, null, 2));
logger.debug('[Channel Push] Channel state:', channel.state);

const result = originalPush(event, payload);

logger.debug('[Channel Push] Push returned, ReceiveHook attached');

return result;
};
logger.debug('Channel push method wrapped for debugging');

// trigger the workloop
if (options.noLoop) {
// @ts-ignore
Expand Down

AltStyle によって変換されたページ (->オリジナル) /