-
Notifications
You must be signed in to change notification settings - Fork 88
Open
Conversation
@MayDomine
MayDomine
requested review from
Achazwl,
a710128 and
zkh2016
and removed request for
a710128 and
zkh2016
August 29, 2023 03:10
zkh2016
zkh2016
reviewed
Aug 29, 2023
@MayDomine
MayDomine
force-pushed
the
tp_offload
branch
from
August 29, 2023 03:35
4185725 to
8bd6475
Compare
zkh2016
zkh2016
reviewed
Aug 29, 2023
from .global_var import config
from .checkpointing import CheckpointBlockContext
from .distributed import all_gather, broadcast, all_reduce, send_activations, recv_activations
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些没用到,可以去掉
Achazwl
Achazwl
reviewed
Aug 29, 2023
ctypes.CDLL(os.path.join(path, file_so))
def find_pre_module_helper(m):
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
find_pre_offload_module_helper
zkh2016
zkh2016
reviewed
Aug 29, 2023
module = CheckpointBlock(module)
module._mode = "ZERO"
module._mode = "ZERO" if module._mode == "BLOCK" else module._mode
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里可以直接去掉,现在不需要区分ZERO和BLOCK了
@MayDomine
MayDomine
force-pushed
the
dev
branch
2 times, most recently
from
April 17, 2024 06:35
0500ae7 to
5dad728
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add async Offload Activation for CheckpointBlock