Search code, repositories, users, issues, pull requests...

@anj20 anj20 commented Feb 12, 2025 •

edited

Loading

Copy link

Copy Markdown

Contributor

Purpose of PR?: Replace the mswms_demodata command with a --seed option for the mswms command, aligning it with the behavior of the seed option in mscolab

Fixes #2631

Does this PR introduce a breaking change?
No

If the changes in this PR are manually verified, list down the scenarios covered::
Verified that the seed function runs correctly when executed using mswms -seed

Checklist:

Bug fix. Fixes #
New feature (Non-API breaking changes that adds functionality)
PR Title follows the convention of <type>: <subject>
Commit has unit tests

anj20 added 2 commits

February 12, 2025 22:47


 feat:command changes

4077a89


 docs:updated

d3b0a52

ReimarBauer requested changes

Feb 13, 2025

mslib/mswms/mswms.py

parser.add_argument("--logfile", help="If set to a name log output goes to that file", dest="logfile",

default=None)

parser.add_argument("-s", "--seed", help="creates demodata for the mswms server",

action="store_true", default=False)

@ReimarBauer ReimarBauer Feb 13, 2025

Copy link

Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and what does this?

Have you tried the examples?

@anj20 anj20 Feb 24, 2025 •

edited

Loading

Copy link

Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and what does this?

Have you tried the examples?

It adds an argument '-s' or '--seed' to enable data seeding using the mswms command.

@ReimarBauer ReimarBauer Feb 24, 2025

Copy link

Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and how is the method called?

Does it create demodata in a dir as the description says?

@anj20 anj20 Feb 24, 2025

Copy link

Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it is not creating

@anj20 anj20 Feb 24, 2025

Copy link

Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u give some hint where to do the changes?

@ReimarBauer ReimarBauer Feb 24, 2025 •

edited

Loading

Copy link

Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look in conftest for an example, this creates also demodata for the tests.

@anj20 anj20 Mar 2, 2025

Copy link

Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi i have added the seed function. Can u jst review it?

@ReimarBauer

ReimarBauer commented Feb 20, 2025

Copy link

Copy Markdown

Member

@anj20 do you have time to finish this in the next days?


 added the seed function

ccff85c

@anj20 anj20 requested a review from ReimarBauer

March 2, 2025 13:17

@ReimarBauer

ReimarBauer commented Mar 3, 2025

Copy link

Copy Markdown

Member

@anj20
please solve the merge conflict


 Merge branch 'develop' into feat/command_changes

d81934e

ReimarBauer reviewed

Mar 3, 2025

mslib/mswms/mswms.py

server_config_fs=fs.open_fs("~/mss"))

examples.create_server_config(detailed_information=True)

examples.create_data()

print("\nTo use this setup you need the mswms_settings.py in your python path e.g. \nexport PYTHONPATH=~/mss")

@ReimarBauer ReimarBauer Mar 3, 2025

Copy link

Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when this is now copied here and we won ́t call mswms_demodata any more the main function of demodata can be removed.

setup.py needs changes

and the docs need changes too

@anj20 anj20 Mar 3, 2025

Copy link

Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok lemme make the changes

@anj20 anj20 Mar 3, 2025

Copy link

Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi do i need to remove the entire main funtion?

@ReimarBauer ReimarBauer Mar 4, 2025

Copy link

Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should not be more copy/paste duplicated code.

ReimarBauer requested changes

Mar 3, 2025

@ReimarBauer ReimarBauer left a comment

Copy link

Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

anj20 added 2 commits

March 3, 2025 14:26


 removed the seed function from demodata

6525ac5


 docs:updated

a57f98a

@anj20

anj20 commented Mar 3, 2025

Copy link

Copy Markdown

Contributor Author

see comments

updated plz review it

@anj20 anj20 requested a review from ReimarBauer

March 3, 2025 09:00

anj20 added 2 commits

March 3, 2025 15:08


 Update README.md

fab245f


 Update README.md

24ee0b5

@ReimarBauer

ReimarBauer commented Mar 4, 2025

Copy link

Copy Markdown

Member

this likly needs a rebase to develop

ReimarBauer requested changes

Mar 4, 2025

@ReimarBauer ReimarBauer left a comment

Copy link

Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments, remove commented off old lines.

README.md

pixi global update mss

@ReimarBauer ReimarBauer Mar 3, 2025

Copy link

Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not part of the issue

README.md

@@ -44,7 +44,6 @@ and don't need server configurations.

##### Updating

pixi global update mss

@ReimarBauer ReimarBauer Mar 4, 2025

Copy link

Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are the changes here?

README.md

We are very grateful for your continuing support for MSS!

See our [Contributors page](https://mss.readthedocs.io/en/stable/authors.html) for a list of authors. See also our info on [funding](

https://mss.readthedocs.io/en/stable/funding.html). No newline at end of file

@ReimarBauer ReimarBauer Mar 4, 2025

Copy link

Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is wrong with the line and how it is related to the task?

mslib/mswms/mswms.py

server_config_fs=fs.open_fs("~/mss"))

examples.create_server_config(detailed_information=True)

examples.create_data()

print("\nTo use this setup you need the mswms_settings.py in your python path e.g. \nexport PYTHONPATH=~/mss")

@ReimarBauer ReimarBauer Mar 4, 2025

Copy link

Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should not be more copy/paste duplicated code.

anj20 and others added 6 commits

March 6, 2025 15:37


 Merge branch 'Open-MSS:develop' into feat/command_changes

dead5c2


 removed comments

2a9e619


 removed comments demodata.py

9ebe5b2


 Revert "Update README.md"

8b2e061

This reverts commit fab245f.


 Revert "Update README.md"

76ba3d7

This reverts commit 24ee0b5.